feat: improved local translation handling #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deborahgu
commented
Jan 29, 2026
deborahgu
commented
- pulls in any extra sources configured for credentials and edxapp
- technically I suppose there could be problems if they aren't in the environment but we are absolutely populating the environment in edx-internal
- added to the credentials docker file twice, because there's 2 different potential images where we build translations
- pulls in any extra sources configured for credentials and edxapp - technically I suppose there could be problems if they aren't in the environment but we are absolutely populating the environment in edx-internal - added to the credentials docker file twice, because there's 2 different potential images where we build translations
timmc-edx
reviewed
Feb 3, 2026
dockerfiles/edx-platform.Dockerfile
Outdated
| ARG OPENEDX_ATLAS_EXTRA_SOURCES | ||
| ARG OPENEDX_TRANSLATIONS_VERSION | ||
| ARG OPENEDX_TRANSLATIONS_REPO | ||
| ENV ATLAS_EXTRA_SOURCES="--repository=$OPENEDX_ATLAS_EXTRA_SOURCES" |
Member
There was a problem hiding this comment.
This should work, but it might be cleaner to include the env var as an export line in the translations RUN block. (Less broad impact, and no inclusion in final image's runtime environment.)
timmc-edx
approved these changes
Feb 3, 2026
Member
timmc-edx
left a comment
timmc-edx
left a comment
There was a problem hiding this comment.
Added suggestion for a more precise application of env vars, but approving.
mild re-factoring of environment variable per code review suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.